cleanup: Define GObject accessors in camelCase

gjs is smart enough to match a propertyName getter/setter to the
corresponding property-name GObject property, so use that and get
rid of the eslint camelcase rule exceptions.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1611>

diff --git a/js/misc/modemManager.js b/js/misc/modemManager.js
index 5f727f3ca2164e061d890840e82cba3280a18f55..c73c93e7fd21d09267af09c731d085178e6d8727 100644 (file)
--- a/js/misc/modemManager.js
+++ b/js/misc/modemManager.js
@@ -117,13 +117,11 @@ var ModemBase = GObject.registerClass({
         this._signalQuality = 0;
     }
 
-    // eslint-disable-next-line camelcase
-    get operator_name() {
+    get operatorName() {
         return this._operatorName;
     }
 
-    // eslint-disable-next-line camelcase
-    get signal_quality() {
+    get signalQuality() {
         return this._signalQuality;
     }
 

diff --git a/js/misc/systemActions.js b/js/misc/systemActions.js
index 1cd65764885820cb7f6f135f0744563fda3de79d..10cab9a9e2ec94a5fc6e06822b68994d74b6c02e 100644 (file)
--- a/js/misc/systemActions.js
+++ b/js/misc/systemActions.js
@@ -182,43 +182,35 @@ const SystemActions = GObject.registerClass({
         this._sessionUpdated();
     }
 
-    // eslint-disable-next-line camelcase
-    get can_power_off() {
+    get canPowerOff() {
         return this._actions.get(POWER_OFF_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get can_restart() {
+    get canRestart() {
         return this._actions.get(RESTART_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get can_suspend() {
+    get canSuspend() {
         return this._actions.get(SUSPEND_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get can_lock_screen() {
+    get canLockScreen() {
         return this._actions.get(LOCK_SCREEN_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get can_switch_user() {
+    get canSwitchUser() {
         return this._actions.get(SWITCH_USER_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get can_logout() {
+    get canLogout() {
         return this._actions.get(LOGOUT_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get can_lock_orientation() {
+    get canLockOrientation() {
         return this._actions.get(LOCK_ORIENTATION_ACTION_ID).available;
     }
 
-    // eslint-disable-next-line camelcase
-    get orientation_lock_icon() {
+    get orientationLockIcon() {
         return this._actions.get(LOCK_ORIENTATION_ACTION_ID).iconName;
     }
 

diff --git a/js/ui/barLevel.js b/js/ui/barLevel.js
index f4fdb6e51a31a8e4624038bc96aeeb2e0a56ba90..25d4835280acda6964609b1d8bb6c17649f3a62f 100644 (file)
--- a/js/ui/barLevel.js
+++ b/js/ui/barLevel.js
@@ -60,13 +60,11 @@ var BarLevel = GObject.registerClass({
         this.queue_repaint();
     }
 
-    // eslint-disable-next-line camelcase
-    get maximum_value() {
+    get maximumValue() {
         return this._maxValue;
     }
 
-    // eslint-disable-next-line camelcase
-    set maximum_value(value) {
+    set maximumValue(value) {
         value = Math.max(value, 1);
 
         if (this._maxValue == value)
@@ -78,13 +76,11 @@ var BarLevel = GObject.registerClass({
         this.queue_repaint();
     }
 
-    // eslint-disable-next-line camelcase
-    get overdrive_start() {
+    get overdriveStart() {
         return this._overdriveStart;
     }
 
-    // eslint-disable-next-line camelcase
-    set overdrive_start(value) {
+    set overdriveStart(value) {
         if (this._overdriveStart == value)
             return;
 

diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index 4af154d6f70ab0ba35bc947047e721df80ca2587..3e8bfee7d53c5d8723edabea48886a92786512ef 100644 (file)
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -336,13 +336,11 @@ var ListSectionItem = GObject.registerClass({
         this.add_child(textLayout);
     }
 
-    // eslint-disable-next-line camelcase
-    get icon_actor() {
+    get iconActor() {
         return this._iconActorBin.get_child();
     }
 
-    // eslint-disable-next-line camelcase
-    set icon_actor(actor) {
+    set iconActor(actor) {
         this._iconActorBin.set_child(actor);
         this.notify('icon-actor');
     }

diff --git a/js/ui/iconGrid.js b/js/ui/iconGrid.js
index fde6c702bac66c3262fc96238cb62b879e8608c2..e8ac2b07edbdb148119b0c7a8f2d8db9b13d9dc1 100644 (file)
--- a/js/ui/iconGrid.js
+++ b/js/ui/iconGrid.js
@@ -1090,8 +1090,7 @@ var IconGridLayout = GObject.registerClass({
         return [null, DragLocation.EMPTY_SPACE];
     }
 
-    // eslint-disable-next-line camelcase
-    get icon_size() {
+    get iconSize() {
         return this._iconSize;
     }
 

diff --git a/js/ui/layout.js b/js/ui/layout.js
index b082ec80b02a29bfdfb410f342beef44aac60f5c..1a41a34beb88db6f04ee45225e0f3a9c0217dbbc 100644 (file)
--- a/js/ui/layout.js
+++ b/js/ui/layout.js
@@ -79,13 +79,11 @@ var MonitorConstraint = GObject.registerClass({
         this.notify('index');
     }
 
-    // eslint-disable-next-line camelcase
-    get work_area() {
+    get workArea() {
         return this._workArea;
     }
 
-    // eslint-disable-next-line camelcase
-    set work_area(v) {
+    set workArea(v) {
         if (v == this._workArea)
             return;
         this._workArea = v;

diff --git a/js/ui/padOsd.js b/js/ui/padOsd.js
index a402fad7effb5e734d56ce7f96cc2e82f9b58ee1..ed207415add056155ca6a67871436f68497fc6a7 100644 (file)
--- a/js/ui/padOsd.js
+++ b/js/ui/padOsd.js
@@ -322,13 +322,11 @@ var PadDiagram = GObject.registerClass({
         this._initLabels();
     }
 
-    // eslint-disable-next-line camelcase
-    get editor_actor() {
+    get editorActor() {
         return this._editorActor;
     }
 
-    // eslint-disable-next-line camelcase
-    set editor_actor(actor) {
+    set editorActor(actor) {
         actor.hide();
         this._editorActor = actor;
         this.add_actor(actor);

diff --git a/js/ui/windowPreview.js b/js/ui/windowPreview.js
index b17c87be3b8d32b9c98b4b35178f51732d43438f..fddb62e26e2c1b1707bf80a690ed69e30d873a60 100644 (file)
--- a/js/ui/windowPreview.js
+++ b/js/ui/windowPreview.js
@@ -188,8 +188,7 @@ var WindowPreviewLayout = GObject.registerClass({
         return [...this._windows.values()].map(i => i.metaWindow);
     }
 
-    // eslint-disable-next-line camelcase
-    get bounding_box() {
+    get boundingBox() {
         return this._boundingBox;
     }
 });
@@ -631,13 +630,11 @@ var WindowPreview = GObject.registerClass({
         };
     }
 
-    // eslint-disable-next-line camelcase
-    get overlay_enabled() {
+    get overlayEnabled() {
         return this._overlayEnabled;
     }
 
-    // eslint-disable-next-line camelcase
-    set overlay_enabled(enabled) {
+    set overlayEnabled(enabled) {
         if (this._overlayEnabled === enabled)
             return;
 

diff --git a/js/ui/workspace.js b/js/ui/workspace.js
index 951f452193a6d848ed1cac17f072358c79f7aa2c..b3ca4cca5292c59033cdaf636fcb1be7e86b87de 100644 (file)
--- a/js/ui/workspace.js
+++ b/js/ui/workspace.js
@@ -851,13 +851,11 @@ var WorkspaceLayout = GObject.registerClass({
         this.layout_changed();
     }
 
-    // eslint-disable-next-line camelcase
-    get layout_frozen() {
+    get layoutFrozen() {
         return this._layoutFrozen;
     }
 
-    // eslint-disable-next-line camelcase
-    set layout_frozen(f) {
+    set layoutFrozen(f) {
         if (this._layoutFrozen === f)
             return;
 

diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index f74c8fecbec2901ffd796660664c623e2422eba0..40a33fe3a34071f11aced4ceaca4caa298ec5c98 100644 (file)
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -334,8 +334,7 @@ var WorkspaceThumbnail = GObject.registerClass({
         }
     }
 
-    // eslint-disable-next-line camelcase
-    set slide_position(slidePosition) {
+    set slidePosition(slidePosition) {
         if (this._slidePosition == slidePosition)
             return;
 
@@ -348,13 +347,11 @@ var WorkspaceThumbnail = GObject.registerClass({
         this.queue_relayout();
     }
 
-    // eslint-disable-next-line camelcase
-    get slide_position() {
+    get slidePosition() {
         return this._slidePosition;
     }
 
-    // eslint-disable-next-line camelcase
-    set collapse_fraction(collapseFraction) {
+    set collapseFraction(collapseFraction) {
         if (this._collapseFraction == collapseFraction)
             return;
         this._collapseFraction = collapseFraction;
@@ -362,8 +359,7 @@ var WorkspaceThumbnail = GObject.registerClass({
         this.queue_relayout();
     }
 
-    // eslint-disable-next-line camelcase
-    get collapse_fraction() {
+    get collapseFraction() {
         return this._collapseFraction;
     }